Repository: bval Updated Branches: refs/heads/master 9171e1cdc -> cd98363fc
BVAL-168: NotEmpty validator should return false for null objects Project: http://git-wip-us.apache.org/repos/asf/bval/repo Commit: http://git-wip-us.apache.org/repos/asf/bval/commit/cd98363f Tree: http://git-wip-us.apache.org/repos/asf/bval/tree/cd98363f Diff: http://git-wip-us.apache.org/repos/asf/bval/diff/cd98363f Branch: refs/heads/master Commit: cd98363fcc37c526254466bfd3496edadbc6dd9c Parents: 9171e1c Author: Matt Benson <[email protected]> Authored: Wed Nov 7 09:28:55 2018 -0600 Committer: Matt Benson <[email protected]> Committed: Wed Nov 7 09:28:55 2018 -0600 ---------------------------------------------------------------------- .../java/org/apache/bval/constraints/NotEmptyValidator.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/bval/blob/cd98363f/bval-jsr/src/main/java/org/apache/bval/constraints/NotEmptyValidator.java ---------------------------------------------------------------------- diff --git a/bval-jsr/src/main/java/org/apache/bval/constraints/NotEmptyValidator.java b/bval-jsr/src/main/java/org/apache/bval/constraints/NotEmptyValidator.java index 92c8739..73b3feb 100644 --- a/bval-jsr/src/main/java/org/apache/bval/constraints/NotEmptyValidator.java +++ b/bval-jsr/src/main/java/org/apache/bval/constraints/NotEmptyValidator.java @@ -20,20 +20,23 @@ package org.apache.bval.constraints; import javax.validation.ConstraintValidator; import javax.validation.ConstraintValidatorContext; +import javax.validation.constraints.NotEmpty; + import java.lang.reflect.Array; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; /** - * Description: Check the non emptiness of an - * any object that has a public isEmpty():boolean or a valid toString() method + * {@link ConstraintValidator} implementation for {@link NotEmpty}. + * Additionally, check the non-emptiness of an + * any object that has a public isEmpty():boolean or a valid toString() method. */ public class NotEmptyValidator implements ConstraintValidator<javax.validation.constraints.NotEmpty, Object> { @Override public boolean isValid(Object value, ConstraintValidatorContext context) { if (value == null) { - return true; + return false; } if (value.getClass().isArray()) { return Array.getLength(value) > 0;
