Javadoc fixes (Alexey Roytman) Javadoc for 'filters' @param of ProjectableFilterableTable.scan() stated the opposite of the truth, and was in conflict with the method javadoc.
Javadoc for RelDataType.getFieldCount() had ()() in its description; fixed. Close apache/calcite#553 Project: http://git-wip-us.apache.org/repos/asf/calcite/repo Commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/67bd5446 Tree: http://git-wip-us.apache.org/repos/asf/calcite/tree/67bd5446 Diff: http://git-wip-us.apache.org/repos/asf/calcite/diff/67bd5446 Branch: refs/heads/master Commit: 67bd5446911bd8d1fe96b646affab844d85bb165 Parents: 4542510 Author: Alexey Roytman <[email protected]> Authored: Fri Oct 27 08:43:07 2017 -0700 Committer: Julian Hyde <[email protected]> Committed: Thu Nov 2 12:56:03 2017 -0700 ---------------------------------------------------------------------- .../org/apache/calcite/adapter/cassandra/CassandraFilter.java | 2 +- core/src/main/java/org/apache/calcite/rel/type/RelDataType.java | 4 ++-- .../org/apache/calcite/schema/ProjectableFilterableTable.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/calcite/blob/67bd5446/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java ---------------------------------------------------------------------- diff --git a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java index ba8aa9c..0bdc7f6 100644 --- a/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java +++ b/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraFilter.java @@ -174,7 +174,7 @@ public class CassandraFilter extends Filter implements CassandraRel { } } - /** Conver the value of a literal to a string. + /** Convert the value of a literal to a string. * * @param literal Literal to translate * @return String representation of the literal http://git-wip-us.apache.org/repos/asf/calcite/blob/67bd5446/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java b/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java index 7b18d67..aa8d495 100644 --- a/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java +++ b/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java @@ -71,8 +71,8 @@ public interface RelDataType /*extends Type*/ { /** * Returns the number of fields in a struct type. * - * <p>This method is equivalent to <code>{@link #getFieldList} - * ().size()</code>. + * <p>This method is equivalent to + * <code>{@link #getFieldList}.size()</code>. */ int getFieldCount(); http://git-wip-us.apache.org/repos/asf/calcite/blob/67bd5446/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java b/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java index 2f56865..f6227c4 100644 --- a/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java +++ b/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java @@ -48,7 +48,7 @@ public interface ProjectableFilterableTable extends Table { * <p>The projects are zero-based.</p> * * @param root Execution context - * @param filters Mutable list of filters. The method should remove from the + * @param filters Mutable list of filters. The method should keep in the * list any filters that it cannot apply. * @param projects List of projects. Each is the 0-based ordinal of the column * to project.
