Repository: calcite
Updated Branches:
  refs/heads/master a5d4a8b53 -> 9ba9bdc1d


[CALCITE-2594] Ensure forbiddenapis and maven-compiler use the correct JDK 
version

Close apache/calcite#867

Signed-off-by: Kevin Risden <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/calcite/repo
Commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/9ba9bdc1
Tree: http://git-wip-us.apache.org/repos/asf/calcite/tree/9ba9bdc1
Diff: http://git-wip-us.apache.org/repos/asf/calcite/diff/9ba9bdc1

Branch: refs/heads/master
Commit: 9ba9bdc1d84804573c8370605e021e6b3fbab3de
Parents: a5d4a8b
Author: Kevin Risden <[email protected]>
Authored: Tue Sep 25 12:41:41 2018 -0400
Committer: Kevin Risden <[email protected]>
Committed: Tue Sep 25 13:01:00 2018 -0400

----------------------------------------------------------------------
 pom.xml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/calcite/blob/9ba9bdc1/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index c5e942b..6783c91 100644
--- a/pom.xml
+++ b/pom.xml
@@ -46,6 +46,11 @@ limitations under the License.
   </mailingLists>
 
   <properties>
+    <!-- Ensure that source and target version are overridden from base ASF 
POM.
+         This is also used by forbiddenapis to ensure correct signatures are 
loaded. -->
+    <maven.compiler.source>8</maven.compiler.source>
+    <maven.compiler.target>8</maven.compiler.target>
+
     <surefire.parallel>both</surefire.parallel>
     <surefire.threadCount>1</surefire.threadCount>
     <surefire.perCoreThreadCount>true</surefire.perCoreThreadCount>
@@ -701,9 +706,9 @@ limitations under the License.
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
+        <!-- If you are looking to change source/target, 
+             change the maven.compiler.{source,target} property -->
         <configuration>
-          <source>8</source>
-          <target>8</target>
           <compilerArgument>-Xlint:deprecation</compilerArgument>
         </configuration>
       </plugin>

Reply via email to