jh3507 commented on a change in pull request #1081: [CALCITE-2888] Enhance
RexImplicationChecker to better handle cast
URL: https://github.com/apache/calcite/pull/1081#discussion_r261818750
##########
File path: core/src/main/java/org/apache/calcite/plan/VisitorDataContext.java
##########
@@ -75,12 +81,27 @@ public static DataContext of(RelNode targetRel,
LogicalFilter queryRel) {
}
public static DataContext of(RelDataType rowType, RexNode rex) {
+ return of(rowType, rex, null, null);
+ }
Review comment:
This has come from the previous definition. I think useless is somewhat
subjective expression. This method is a public static method in a public class.
I personally don't make this function call, but someone might be already using
it. I didn't want to abruptly remove a public method. Also, giving nulls to
builder and executor would make it possible to bypass the executor so that the
output you get from it would be exactly the same as before. So, I think this
can be useful especially for those who think this change is not necessary :)
That being said, I am okay with removing existing 'of' methods if the community
is okay with it.
Also, as far as I know, this can never be a constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
