asereda-gs commented on a change in pull request #1095: [CALCITE-2599] add the
ASCII function
URL: https://github.com/apache/calcite/pull/1095#discussion_r264004765
##########
File path: site/_docs/reference.md
##########
@@ -1447,10 +1448,10 @@ period:
| {fn SUBSTRING(string, offset, length)} | Returns a character string that
consists of *length* characters from *string* starting at the *offset* position
| {fn UCASE(string)} | Returns a string in which all alphabetic characters in
*string* have been converted to upper case
| {fn REPLACE(string, search, replacement)} | Returns a string in which all
the occurrences of *search* in *string* are replaced with *replacement*; if
*replacement* is the empty string, the occurrences of *search* are removed
+| {fn ASCII(string)} | Returns the corresponding ASCII code of the first
character of *string*; Returns 0 if *string* is empty; Returns NULL if *string*
is NULL
Review comment:
Let's agree on behaviour of `ASCII` function for non-basic ASCII characters
(> `0x7E`). This includes extended ASCII (eg. LATIN) and UNICODE.
Should we also support more generic
[UNICODE](https://docs.microsoft.com/en-us/sql/t-sql/functions/unicode-transact-sql?view=sql-server-2017)
function ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
