julianhyde commented on a change in pull request #1110: [CALCITE-2920]
RelBuilder: new method to create an antijoin
URL: https://github.com/apache/calcite/pull/1110#discussion_r266184045
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -1733,6 +1733,47 @@ public RelBuilder semiJoin(RexNode... conditions) {
return semiJoin(ImmutableList.copyOf(conditions));
}
+ /** Creates an AntiJoin: since, for the moment, there is no "AntiJoin"
expression, the only
+ * possibility to build an AntiJoin is using a LogicalCorrelate with
SemiJoinType.ANTI */
Review comment:
Can you make this into a comment that is useful to the user? Explain what an
ant-join is. A SQL example works well.
Maybe add a similar description to `semiJoin`.
Description of the limitations of the algebra can be moved to a non-javadoc
comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
