asereda-gs commented on issue #1031: [CALCITE-2742] Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-473597423 @siddharthteotia did you address Julian's comment about flaky test (see `testTimestampFromContext`) eg. check for a range of correct values ? Also why `JdbcTest.testReuseExpressionWhenNullChecking3` was changed from `user = 'sa' ` to `CURRENT_PATH = ''`. There is no way to set that variable explicitly in test ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
