chunweilei commented on a change in pull request #1108: [CALCITE-863] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function URL: https://github.com/apache/calcite/pull/1108#discussion_r266713127
########## File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java ########## @@ -38,6 +38,7 @@ private final boolean requiresOrder; private final boolean requiresOver; private final Optionality requiresGroupOrder; + private final Boolean ignoreNulls; Review comment: Thanks @julianhyde. Actually the default is `RESPECT NULLS`(Oracle: https://docs.oracle.com/cd/E11882_01/server.112/e41084/functions082.htm#SQLRF00652). But your point makes sense. I would like to try it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
