chunweilei commented on a change in pull request #1108: [CALCITE-883] Support
RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value
function
URL: https://github.com/apache/calcite/pull/1108#discussion_r267358852
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java
##########
@@ -210,6 +210,9 @@ public Result implement(EnumerableRelImplementor
implementor, Prefer pref) {
List<AggregateCall> aggregateCalls = group.getAggregateCalls(this);
for (int aggIdx = 0; aggIdx < aggregateCalls.size(); aggIdx++) {
AggregateCall call = aggregateCalls.get(aggIdx);
+ if (call.ignoreNulls()) {
+ throw new UnsupportedOperationException("Do not support ignore nulls
now");
+ }
aggs.add(new AggImpState(aggIdx, call, true));
Review comment:
It throws exception because I don't implement `IGNORE NULLS` for now. I want
to make sure I am in the right way before implementing it. Besides, I add a
test in `JDBCTest` to ensure it works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
