vlsi commented on a change in pull request #88: [hotfix] fix typo in
AbstractService
URL: https://github.com/apache/calcite-avatica/pull/88#discussion_r269089364
##########
File path:
core/src/main/java/org/apache/calcite/avatica/remote/AbstractService.java
##########
@@ -89,7 +89,7 @@ ColumnMetaData finagle(ColumnMetaData column) {
case PROTOBUF:
return column;
default:
Review comment:
Just my 2c: @leesf , would you please care to add input
`getSerializationType()` as long as you modify the line?
Then failure message would contain something to analyze rather than obscure
`Unhandled case statement`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services