asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-476654369 Overall LGTM. The only thing I'm debating is what arguments to provide to constructor: 1. `GemfireCache cache, Iterable<String> names` - current version 2. `GemfireCache cache, Set<String> names` since we know names should be unique 3. `GemfireCache cache, Predicate<String> filter` to allow regexp filtering (?) 4. `Iterable<Region<?,?>> regions`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
