vlsi commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477048459 @zabetak , I'm afraid I'm with Julian. Each message generates GitHub notification, and it does create disruptions. It forces everybody to spend time on opening the discussion. As you can see, Julian even navigated here and created a comment. Do you think it is the first time he "reviewed this PR"? Of course the PR is trivial, and in my opinion committer should just commit the change and that's it. "Please rebase and squash" generates extreme amount of notifications (see https://github.com/apache/calcite-avatica/watchers ) which is really sad. That is why I prefer to just rebase/squash/etc on my own when I commit PRs. > There a was a fruitful discussion on if we want to have default case in enumerations Those cases should probably be discussed on the mailing list. PS. Really sorry to pile up the notifications.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
