joshelser commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load 
leaks InputStream
URL: https://github.com/apache/calcite-avatica/pull/90#issuecomment-477214905
 
 
   > The code implements a fallback logic if Exception happens, so exception 
should not be re-thrown?
   
   I'm more worried because I can't think of a "normal" reason that we should 
ever get an IOException thrown when reading a file like this. I would want to 
know that it happened via a hard-fail (unchecked exception).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to