danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270724421
########## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java ########## @@ -16,16 +16,41 @@ */ package org.apache.calcite.materialize; +import org.apache.calcite.plan.RelOptTable; + import java.util.List; /** * Estimates row counts for tables and columns. * Review comment: The comments are not that accurate, we should add isKey and isForeignKey ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
