rubenada commented on a change in pull request #1112: [CALCITE-2930]
FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
IllegalStateException (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1112#discussion_r270741433
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -2380,6 +2381,8 @@ public static boolean classifyFilters(
joinRel.getInputs().get(1).getRowType().getFieldList();
final int nFieldsRight = rightFields.size();
assert nTotalFields == (joinRel instanceof SemiJoin
Review comment:
Thanks all for your comments. The purpose of this PR is just to fix the
IllegalStateException in FilterCorrelateRule.java, so I'd say let's keep the
assert, and I'll squash the commits so this can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services