julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve
how LatticeSuggester deduces foreign keys
URL: https://github.com/apache/calcite/pull/1141#discussion_r270745852
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5652,6 +5652,24 @@ SqlCall withinGroup(SqlNode arg) :
}
}
+SqlCall nullTreatment(SqlCall arg) :
+{
+ final Span span;
+}
+{
+ (
+ <IGNORE> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.IGNORE_NULLS.createCall(
+ span.end(this), arg);
+ }
+ |
+ <RESPECT> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.RESPECT_NULLS.createCall(
+ span.end(this), arg);
+ }
+ )
+}
+
Review comment:
I pushed the first 2 commits to master very soon after opening this PR. The
delta between master and this PR is therefore just one commit,
0c0e908b64949095af1c9c21815880089f52c34f. I assumed that github would figure
that out, but it didn't. Please just consider that commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
