zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any 
project/filter
URL: https://github.com/apache/calcite/pull/1030#issuecomment-478773814
 
 
   SqlToRelConverter should use the RelBuilderFactory provided in the 
configuration. As you observed there are places where this does not happen. To 
me this appears like a bug so you could maybe fix it as part of this PR. With a 
first glance it does not look so complicated to replace hardcoded factories 
with those in the configuration.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to