siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-478775561 > SqlToRelConverter should use the RelBuilderFactory provided in the configuration. As you observed there are places where this does not happen. To me this appears like a bug so you could maybe fix it as part of this PR. With a first glance it does not look so complicated to replace hardcoded factories with those in the configuration. @zabetak , One thing that I wasn't really able to see is how to get a particular factory out of RelBuilderFactory. As you said, SqlToRelConverter's config has RelBuilderFactory available as config.getRelBuilderFactory()... my question is how do I now get the specific factory out of this? Like, for the particular hard-coded case I pointed to... I need something like config.getRelBuilderFactory().getFilterFactory() There is no such method or equivalent to getFilterFactory().
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
