zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r271558302
########## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ########## @@ -4465,6 +4465,14 @@ private void checkNullOperand(SqlTester tester, String op) { + "with conditional wrapper)", "[100]", "VARCHAR(2000)"); + //omit quotes test + tester.checkString("json_query('{\"foo\":\"100\"}', 'strict $.foo' " Review comment: As a comparison, could you please add a case for the flag `KEEP QUOTES`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services