hsyuan commented on a change in pull request #1130: [CALCITE-2865]
FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is
true
URL: https://github.com/apache/calcite/pull/1130#discussion_r272438990
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
##########
@@ -155,8 +158,12 @@ public void onMatch(RelOptRuleCall call) {
final RelBuilder relBuilder = call.builder();
RelNode newFilterRel;
if (copyFilter) {
- newFilterRel = filter.copy(filter.getTraitSet(), project.getInput(),
- simplifyFilterCondition(newCondition, call));
+ final RelNode input = project.getInput();
+ final RelTraitSet traitSet = filter.getTraitSet()
+ .replaceIfs(RelCollationTraitDef.INSTANCE,
Review comment:
AggregateStarTableRule, FilterAggregateTransposeRule,
AggregateProjectMergeRule, FilterJoinRule, FilterMergeRule, ProjectMergeRule...
Their default instances all matches both logical and physical operators, but
they all use RelBuilder to build logical operators. Some rules like
AggregateJoinTransposeRule, the default instance only matches logical
operators. There is no consistency among those rules. IMHO, rather than fix it,
we should just remove or deprecate the option of copyFilter, let the rule
always match logical operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
