joshelser commented on issue #85: [CALCITE-2704] Avoid use of ISO-8859-1 to parse request in JsonHandler URL: https://github.com/apache/calcite-avatica/pull/85#issuecomment-481243649 > I've no idea how to test the change though, so please don't ask me to add tests. Thank you. https://github.com/apache/calcite-avatica/blob/master/server/src/test/java/org/apache/calcite/avatica/remote/RemoteMetaTest.java This is the easiest place to add a new test. It should be quite obvious how to do this (just JDBC). Did you test this by hand to validate your fix since you didn't write a test?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
