danny0405 commented on a change in pull request #86: [CALCITE-2882] Set dirty
true when open connection
URL: https://github.com/apache/calcite-avatica/pull/86#discussion_r274871459
##########
File path:
server/src/test/java/org/apache/calcite/avatica/remote/AvaticaServersForTest.java
##########
@@ -163,8 +165,12 @@ public String getJdbcUrl(int port, Serialization
serialization, String urlSuffix
static JdbcMeta getInstance() {
if (instance == null) {
try {
- instance = new JdbcMeta(CONNECTION_SPEC.url,
CONNECTION_SPEC.username,
- CONNECTION_SPEC.password);
+ Properties info = new Properties();
+ info.put(JdbcMeta.ConnectionCacheSettings.EXPIRY_DURATION.key(),
"10");
+ info.put(JdbcMeta.ConnectionCacheSettings.EXPIRY_UNIT.key(),
TimeUnit.SECONDS.name());
Review comment:
Does this expire time config has any side effect with the test already ? I'm
a little worry about it, maybe you can make these 2 params configurable and set
them in your test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
