julianhyde commented on issue #1153: [CALCITE-1338] JoinProjectTransposeRule makes wrong transformation when the right child of left outer join has a RexLiteral project expression URL: https://github.com/apache/calcite/pull/1153#issuecomment-482748259 In future, when you make code changes after a review, could you add new commits rather than amending existing commits? It's easier to review the deltas. (Obviously you need to force-push in order to rebase or change the commit message.) As a reviewer I am happy to squash and rebase (as long as rebase is clean or relatively easy). I'm re-reviewing now, hopefully will be able to commit to master, so don't touch the branch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
