zabetak commented on a change in pull request #86: [CALCITE-2882] Set dirty
true when open connection
URL: https://github.com/apache/calcite-avatica/pull/86#discussion_r275559518
##########
File path:
server/src/test/java/org/apache/calcite/avatica/remote/AvaticaServersForTest.java
##########
@@ -70,6 +71,31 @@ public void startServers() throws Exception {
serversBySerialization.put(Serialization.PROTOBUF, protobufServer);
}
+ /**
+ * Starts Avatica servers for each serialization type with the properties.
+ */
+ public void startServers(Properties properties) {
Review comment:
The method is almost the same with the one below. How about a small
refactoring?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
