bakea commented on a change in pull request #86: [CALCITE-2882] Set dirty true
when open connection
URL: https://github.com/apache/calcite-avatica/pull/86#discussion_r275655362
##########
File path:
server/src/test/java/org/apache/calcite/avatica/remote/AvaticaServersForTest.java
##########
@@ -164,7 +190,20 @@ static JdbcMeta getInstance() {
if (instance == null) {
try {
instance = new JdbcMeta(CONNECTION_SPEC.url,
CONNECTION_SPEC.username,
- CONNECTION_SPEC.password);
+ CONNECTION_SPEC.password);
+ } catch (SQLException e) {
+ throw new RuntimeException(e);
+ }
+ }
+ return instance;
+ }
+
+ static JdbcMeta getInstance(Properties properties) {
+ if (instance == null) {
Review comment:
Good suggestion, I made a mistake.
I new a `PropertyRemoteJdbcMetaFactory` to handle instance with `Properties`
instead of `FullyRemoteJdbcMetaFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
