walterddr commented on issue #1170: [CALCITE-3008] Create AuxiliaryConverterFactory URL: https://github.com/apache/calcite/pull/1170#issuecomment-484299674 > Why do you want pass factory class instead of just interface AuxiliaryConverter in SqlToRelConverter? That's actually a good point. SqlToRelConverter requires us to generate one AuxiliaryConverter instance for each SqlFunction (e.g. the List), so it would be very inefficient to pass a reflective class object and then call the newInstance method. I do have the option to change the AuxiliaryConverter API to do ``` RexNode convert(RexBuilder rexBuilder, RexNode groupCall, RexNode e, SqlFunction sqlCall); ``` With the extra parameter, we can make the AuxiliaryConverter static. This require to change a public interface which I hesitated to do so. Any advice?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
