chunweilei edited a comment on issue #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-484757984 Update the PR including: * Rename `removeJoin` to `canRemoveJoin` * Use `RexUtil#shift` to transform expressions * Rename 'transformAggregateCall' to 'shift' * Simplify some `if` conditions to `leftKeys.stream().anyMatch(s -> s >= leftBottomChildSize)` * Add some comments @hsyuan Please review the PR when you are free. Thanks a lot.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
