zhztheplayer commented on a change in pull request #1149: [CALCITE-2982]
SqlItemOperator should throw understandable exception …
URL: https://github.com/apache/calcite/pull/1149#discussion_r278487002
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java
##########
@@ -89,6 +91,17 @@
}
final RelDataType operandType = callBinding.getOperandType(0);
final SqlSingleOperandTypeChecker checker = getChecker(operandType);
+ if (checker == null) {
+ SqlNode node = callBinding.getCall()
Review comment:
There is a util method for generating readable signature error:
https://github.com/apache/calcite/blob/986a2d579c8f9b9f08aa9bbbfe11efc4e7bb0809/core/src/main/java/org/apache/calcite/sql/SqlCallBinding.java#L279-L284
Is it enough to use that method rather than manually create new error
messages?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
