danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql
dialect table operator factory to support all …
URL: https://github.com/apache/calcite/pull/1181#discussion_r278792558
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -803,7 +804,9 @@ public void _testConvertAndTranslate() {
checkWholeExpFails("translate('aabbcc', 'ab', '+-')",
"No match found for function signature TRANSLATE3\\(<CHARACTER>,
<CHARACTER>, <CHARACTER>\\)");
tester = tester.withOperatorTable(
- ChainedSqlOperatorTable.of(OracleSqlOperatorTable.instance(),
+ ChainedSqlOperatorTable.of(SqlDialectOperatorTableFactory
+ .instance()
+ .getOperatorTable(SqlDialect.Dialect.ORACLE),
Review comment:
I agree, will format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
