pengzhiwei2018 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278834827
########## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlFlavor.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql.fun; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** + * An annotation used by {@link SqlDialectOperatorTableFactory} to mark which sql dialects + * a sql function belongs to. + * + * <p>We name it SqlFlavor cause there is already a class {@link org.apache.calcite.sql.SqlDialect}. Review comment: should be 'because' here ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
