julianhyde commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279147198
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Join.java
##########
@@ -230,6 +237,17 @@ public boolean isSemiJoinDone() {
return false;
}
+ /**
+ * Returns whether this LogicalJoin is a semi-join but does
+ * not comes from decorrelate.
+ *
+ * @return true if this is semi but without correlate variables.
+ */
+ public boolean isNonCorrelateSemiJoin() {
+ return (this.variablesSet == null || this.variablesSet.size() == 0)
+ && joinType == JoinRelType.SEMI;
+ }
Review comment:
I can’t imagine how to achieve a nested-loop join without a correlating
variable. The left side sets it for each row, and the right side restarts and
applies some condition that uses the variable. So we’re just arguing over
nomenclature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
