FaxianZhao opened a new pull request #1188: [CALCITE-3034] Test case description is not match code logical URL: https://github.com/apache/calcite/pull/1188 The javadoc of the o.a.c.t.CsvTest#testFilterableWhere2 is 'Filter that can be partly handled by CsvFilterableTable.' Actually it never handle it, o.a.c.a.c.CsvFilterableTable#scan will get the whole WHERE condition RexNode and that's SqlKind is AND. So, the code logical will retrun false directly. By the way, due to o.a.c.i.TableScanNode#createFilterable will check whether optimized filters are belong to original filters. So, we cannot refine the operands of AND.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
