danny0405 commented on issue #1188: [CALCITE-3034] CSV test case description does not match it's code logic URL: https://github.com/apache/calcite/pull/1188#issuecomment-487550790 > > What this code changes fixes ? I'm not that clear, can you give a test case ? > > Hi, @danny0405 > Previously, test case o.a.c.t.CsvTest#testFilterableWhere2 won't trigger the `filterValues` of o.a.c.a.c.CsvFilterableTable#scan. > But it's javadoc is 'Filter that can be partly handled by CsvFilterableTable.' If I haven't misunderstanding the mean of 'partly handled', I think the test case is not match javadoc. > So, I create this PR. Then just add a mokito test that detect the `filterValues` is trigged.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
