julianhyde commented on a change in pull request #1196: Site: Improve 
contribution guidelines for JIRA
URL: https://github.com/apache/calcite/pull/1196#discussion_r280993737
 
 

 ##########
 File path: site/_docs/howto.md
 ##########
 @@ -457,12 +457,27 @@ particular release managers.
 
 ## Merging pull requests (for Calcite committers)
 
 
 Review comment:
   Add "These are instructions for a Calcite committer who has reviewed a pull 
request from a contributor, found it satisfactory, and is about to merge it to 
master. Usually the contributor is not a committer (otherwise they would be 
committing it themselves, after you gave approval in a review)."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to