julianhyde commented on issue #96: support from unix timestamp to string date URL: https://github.com/apache/calcite-avatica/pull/96#issuecomment-490600716 In SQL, timestamps are zoneless, whereas in Unix they are relative to the UTC epoch. Existing methods that have 'unix' in the name and have `long` arguments and/or results follow the SQL semantics. (I apologize that the names are misleading. I wanted to capture the fact that it is milliseconds since 1970, but not that it was relative to 1970 UTC.) Your method assumes that the `long` value is relative to UTC. That is opposite to how Avatica does things (although it is the natural way for Java folks to do things), and will confuse people.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
