julianhyde commented on a change in pull request #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#discussion_r283979211
########## File path: sqlline ########## @@ -37,7 +37,7 @@ if [ ! -f target/fullclasspath.txt ]; then fi CP= -for module in core cassandra druid elasticsearch2 elasticsearch5 file mongodb server spark splunk geode example/csv example/function; do +for module in core cassandra druid elasticsearch2 elasticsearch5 file mongodb server spark splunk geode example/csv example/function kafka; do Review comment: Putting it at the end is, of course, the modest thing to do. I learned a while ago that being modest (especially when editing files with lots of unit test methods) creates what DBMS folks call a hot-spot. Everyone adds at the end, so we get merge conflicts. Make your change in the most logical place (which is alphabetical if there is no other organizing principle). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
