asereda-gs commented on a change in pull request #1180: [CALCITE-3023] Upgrade
to Elasticsearch 7.0.0
URL: https://github.com/apache/calcite/pull/1180#discussion_r284041587
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchTable.java
##########
@@ -263,6 +257,12 @@ String scriptedFieldPrefix() {
// cleanup query. remove empty AGGREGATIONS element (if empty)
emptyAggRemover.accept(query);
+ // This must be set to true or else in 7.X and 6/7 mixed clusters
+ // will return lower bounded count values instead of an accurate count.
+ if (groupBy.isEmpty() && ElasticsearchVersion.ES6.compareTo(version) <= 0)
{
Review comment:
I wonder if comparing enum ordinals is a little error-prone ?
Not sure there is a better option without larger code changes (maybe instead
of enum have `int elasticVersionMajor`). Thinking loud.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
