hsyuan commented on a change in pull request #1207: [CALCITE-3062] Do not
populate provenanceMap if not debug
URL: https://github.com/apache/calcite/pull/1207#discussion_r284078593
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -276,6 +276,9 @@ public VolcanoPlanner(RelOptCostFactory costFactory, //
super(costFactory == null ? VolcanoCost.FACTORY : costFactory, //
externalContext);
this.zeroCost = this.costFactory.makeZeroCost();
+ // If LOGGER is debug enabled, enable provenance information to be captured
+ this.provenanceMap = LOGGER.isDebugEnabled() ? new HashMap<>()
+ : Util.blackholeMap();
Review comment:
Do we need a black hole map? Can't we just use this?
```
this.provenanceMap = new HashMap<RelNode, Provenance>() {
@Override public Provenance put(final RelNode key, final Provenance
value) {
return LOGGER.isDebugEnabled() ? super.put(key, value) : null;
}
};
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
