[GitHub] [calcite] laurentgo commented on a change in pull request #765: [CALCITE-2421] Improve RexSimplify when unknownAsFalse is true

[GitBox]

laurentgo commented on a change in pull request #765: [CALCITE-2421] Improve 
RexSimplify when unknownAsFalse is true
URL: https://github.com/apache/calcite/pull/765#discussion_r285308244
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
 ##########
 @@ -312,7 +312,7 @@ private void simplifyList(List<RexNode> terms) {
   }
 
   private void simplifyAndTerms(List<RexNode> terms) {
-    RexSimplify simplify = withUnknownAsFalse(false);
+    RexSimplify simplify = this;
 
 Review comment:
   Yes, looks like already fixed. Should I still work on adding the test cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services