ambition119 edited a comment on issue #1209: [CALCITE-2601] Add REVERSE function URL: https://github.com/apache/calcite/pull/1209#issuecomment-493819775 > Also please resolve conflicts and squash commits. Thank you for your reminders and suggestions, because I am merge apache/master into origin/reverse_fun, so now squash commits is more troublesome, these commit code enter this PR, such as Files changed is not 8 but 64, this already has a comment description(`Is conflicts lead AppVeyor was unable to build ? If I resolved the conflicts, then it’s not good to go to squash commits to one. thanks`). ```shell pick 62cf3d1dc [CALCITE-2601] Add REVERSE function pick d0a06f786 [CALCITE-3061] Query with WITH clause fails when alias is the same as the table with rolled up column pick c25b29c0c [CALCITE-2803] ProjectTransposeJoinRule messes INDF expressions pick 2a2140f98 Site: Add Danny Chan as committer pick b039a36a3 [CALCITE-3034] CSV test case description does not match it's code logic (FaxianZhao) pick 3f24710db [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" pick e98c779d1 [CALCITE-3017] Improve null handling of JsonValueExpressionOperator pick a5b382abb [CALCITE-3028] Support FULL OUTER JOIN with AggregateJoinTransposeRule (Vineet Garg) pick d6896202c [CALCITE-3066] RelToSqlConverter may incorrectly throw an AssertionError for some decimal literals pick 046bb81a9 [CALCITE-3052] Error while applying rule MaterializedViewAggregateRule(Project-Aggregate): ArrayIndexOutOfBoundsException pick 051058be8 [CALCITE-2282] Remove sql operator table from parser pick 7df06784a [CALCITE-2933] Add timestamp extract for casts from timestamp type to other types pick 999c41d5f [CALCITE-2975] Implement JSON_REMOVE function (xuqianjin) pick c6b6800c2 [CALCITE-3062] Do not populate provenanceMap if not debug pick ca92ce27c [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators pick 4d0477305 [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE pick cc73fe525 merge conflicts pick 020c60bad fix doc ``` By the way, this is not my first PR, The code that has been merged is https://github.com/apache/calcite/blob/master/server/src/main/java/org/apache/calcite/sql/ddl/SqlCreateFunction.java
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
