zhztheplayer commented on a change in pull request #1150: [CALCITE-2985]
Implement JSON_STORAGE_SIZE function
URL: https://github.com/apache/calcite/pull/1150#discussion_r285617984
##########
File path: core/src/test/java/org/apache/calcite/test/SqlJsonFunctionsTest.java
##########
@@ -534,13 +534,26 @@ public void testJsonKeys() {
@Test
public void testJsonRemove() {
assertJsonRemove(
- JsonFunctions.jsonValueExpression("{\"a\": 1, \"b\": [2]}"),
- new String[]{"$.a"},
- is("{\"b\":[2]}"));
+ JsonFunctions.jsonValueExpression("{\"a\": 1, \"b\": [2]}"),
Review comment:
I am not sure if our checkstyle checkers works appropriately in this case,
but we actually use the number 4 for continuation indent. Please adjust
accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
