ambition119 commented on a change in pull request #1163: [CALCITE-2995] 
Implement the DAYNAME,MONTHNAME function
URL: https://github.com/apache/calcite/pull/1163#discussion_r286020449
 
 

 ##########
 File path: site/_docs/reference.md
 ##########
 @@ -1510,10 +1510,6 @@ Not implemented:
 | {fn TIMESTAMPADD(timeUnit, count, datetime)} | Adds an interval of *count* 
*timeUnit*s to a datetime
 | {fn TIMESTAMPDIFF(timeUnit, timestamp1, timestamp2)} | Subtracts 
*timestamp1* from *timestamp2* and returns the result in *timeUnit*s
 
-Not implemented:
-
-* {fn DAYNAME(date)}
-* {fn MONTHNAME(date)}
 
 Review comment:
   JDBC String function` {fn DAYNAME(date)}` and `{fn RIGHT(string, integer)}` 
not create in` SqlJdbcFunctionCall `and `SqlOperatorBaseTest.testJdbcFn()` not 
test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to