laurentgo commented on a change in pull request #1229: [CALCITE-3085] Remove
RelShuttleImpl#stack protected field
URL: https://github.com/apache/calcite/pull/1229#discussion_r288218764
##########
File path: core/src/main/java/org/apache/calcite/rel/RelShuttleImpl.java
##########
@@ -44,24 +42,18 @@
* any children change.
*/
public class RelShuttleImpl implements RelShuttle {
- protected final Deque<RelNode> stack = new ArrayDeque<>();
/**
* Visits a particular child of a parent.
*/
protected RelNode visitChild(RelNode parent, int i, RelNode child) {
- stack.push(parent);
- try {
Review comment:
Stack needs to be created, resized and populated. Considering content is
never read, I consider this overhead (especially when queries are deep trees).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
