julianhyde commented on a change in pull request #1254: [CALCITE-2744] fix
RuntimeException in RelDecorrelator when decorrelate aggregate with multi-param
aggregate function
URL: https://github.com/apache/calcite/pull/1254#discussion_r290411649
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -467,6 +468,9 @@ public Frame decorrelateRel(LogicalAggregate rel) {
}
final RelNode newInput = frame.r;
+ // aggregate outputs mappings: group keys + aggregates
+ Map<Integer, Integer> outputsMapping = Maps.newHashMap();
Review comment:
make final; use `new HashMap<>()`; rename to outputMap; can you re-use
`combinedMap`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
