danny0405 commented on a change in pull request #1246: [CALCITE-2968] New
AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291146540
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1322,9 +1351,10 @@ private void closeInner() {
final Enumerable<TSource> outer, final Enumerable<TInner> inner,
final Predicate2<TSource, TInner> predicate,
Function2<TSource, TInner, TResult> resultSelector,
- final boolean generateNullsOnLeft,
- final boolean generateNullsOnRight) {
+ final JoinType joinType) {
Review comment:
@zabetak One reason I didn't deprecate the redundant link4j
CorrelateJoinType/JoinType in CALCITE-2969 is that calcite-link4j is a
separate/single module from calcite-core, while the calcite-core depends on
calcite-link4j, so we may need to keep the redundant, it's not that bad because
these interfaces are not ambiguous and users of other system would not use them
actually.
I suggest to not let this be blocker for merging this in 1.20.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
