MGelbana commented on a change in pull request #1250: [CALCITE-3108] Babel
parser should parse the PostgreSQL TEXT type
URL: https://github.com/apache/calcite/pull/1250#discussion_r291311863
##########
File path: babel/src/main/codegen/config.fmpp
##########
@@ -833,6 +835,7 @@ data: {
# Return type of method implementation should be "SqlIdentifier".
# Example: SqlParseTimeStampZ().
dataTypeParserMethods: [
+ "PostgreSQLTypes"
Review comment:
I thought having a single method for all PostgreSQL types would be more
reusable. But @michaelmior raised a valid flag since `TEXT` is not used by
PostgreSQL only.
Do you happen to know how different is what I did and what @julianhyde is
asking ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
