danny0405 commented on a change in pull request #1275: [CALCITE-3136]Fix the
default rule description of ConverterRule
URL: https://github.com/apache/calcite/pull/1275#discussion_r296446174
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptRule.java
##########
@@ -100,7 +100,7 @@ public RelOptRule(RelOptRuleOperand operand,
if (description == null) {
description = guessDescription(getClass().getName());
}
- if (!description.matches("[A-Za-z][-A-Za-z0-9_.():]*")) {
+ if (!description.matches("[A-Za-z][-A-Za-z0-9_.(),\\[\\]:]*")) {
throw new RuntimeException("Rule description '" + description
Review comment:
Why add `[` and `]` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
