zabetak commented on issue #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet URL: https://github.com/apache/calcite/pull/1257#issuecomment-506074137 Thanks for the update @wenhuitang . I've seen what you are trying to do by overriding `JdbcConvention.toString()` but I am afraid it might backfire on us: - The debug logs of the planner and possibly other places will be more difficult to read. -All JdbcRules are going to be registered to the planner even if they come from the same convention (instantiated multiple times). I have to think a bit if there is another alternative and if it is really worth it getting into the process of normalizing the convention name. Give me a few days to think on it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
