danny0405 commented on a change in pull request #1257: [CALCITE-3115] Add
JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet
URL: https://github.com/apache/calcite/pull/1257#discussion_r297921997
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -426,7 +426,7 @@ protected JdbcJoin(
private JdbcCalcRule(JdbcConvention out,
RelBuilderFactory relBuilderFactory) {
super(Calc.class, (Predicate<RelNode>) r -> true, Convention.NONE,
- out, relBuilderFactory, "JdbcCalcRule");
+ out, relBuilderFactory, "JdbcCalcRule:" + out);
Review comment:
Can we have a uniform method to generate the name pattern for JDBC rules ?
Because the pattern rules for all the rules are the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
