rubenada commented on a change in pull request #1279: [CALCITE-3128] Joining
two tables producing only NULLs will return 0 …
URL: https://github.com/apache/calcite/pull/1279#discussion_r298041785
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java
##########
@@ -229,7 +229,10 @@ private Result implementHashJoin(EnumerableRelImplementor
implementor, Prefer pr
Expressions.constant(joinType.generatesNullsOnLeft()))
.append(
Expressions.constant(
- joinType.generatesNullsOnRight())))).toBlock());
+ joinType.generatesNullsOnRight()))
+ .append(
+ Expressions.constant(
Review comment:
Minor detail. We could simplify this expression with Expressions.list and
four append:
```
Expressions.list(
A, B, C, D)
.append(E)
.append(F)
.append(G)
.append(H)
```
by just moving the append parameters directly inside the Expressions.list
(and get rid of all the append calls):
```
Expressions.list(
A, B, C, D, E, F, G, H)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
